Bugfix: Change textrules API to pass line: Option<&str>.
#261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Called Option1 in dalance#257.
DaveMcEwan
added a commit
to DaveMcEwan/svlint-plugin-sample
that referenced
this pull request
Jul 3, 2023
- Same issue as <dalance/svlint#257> - Matches <dalance/svlint#261>.
DaveMcEwan
added a commit
to DaveMcEwan/svlint-plugin-sample
that referenced
this pull request
Jul 3, 2023
- More descriptive than `Option<&str>`. - Same issue as <dalance/svlint#257> - Matches <dalance/svlint#261>.
|
@dalance Would you mind having a look at this? |
|
Sorry for the late reply. |
|
I released v0.9.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After discussion on Bug: Textrule header_copyright only checks the first file passed #257, @skjdbg and I think this is a more flexible solution.
&str, pass asOption<&str>.Rules should interpret
Some(x)as a line of text, andNoneas a signal that a new item from the list of files is about to be processed.This allows textrules to reset (or otherwise update) any internal state machines.
svlint foo.sv bar.sv, and the textruleheader_copyrightdoesn't reset its line counter.This change resets the counter before each file is processed.
Cargo.tomlis pinned to svlint v0.8.0, but if this accepted, perhaps with another release, I'll update it ASAP.TextRulesEventsvlint-plugin-sample#8Needs a new version to pin against before it's mergable.